Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor to modules and add ddos #175

Merged
merged 23 commits into from
Oct 8, 2024

Conversation

jaredfholgate
Copy link
Member

@jaredfholgate jaredfholgate commented Oct 8, 2024

Overview/Summary

Replacing the complete-multi-region starter module with a modular implementation that leverages native Terraform inputs.

Also adding ddos plan and other minor fixes / improvements.

Please note that the examples folder and the yaml.tf file are deleted by the ALZ PowerShell module, so they do not get pushed to source control.

The purpose of the yaml.tf file is to enable us to spit out a config YAML file that is used in the docs since we now use a tfvars files for the local testing. See the sister PR for those files: Azure/ALZ-PowerShell-Module#214

This PR fixes/adds/changes/removes

N/A

Breaking Changes

This is a breaking change to the complete-multi-region starter module.

Testing Evidence

Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@jaredfholgate jaredfholgate self-assigned this Oct 8, 2024
@jaredfholgate jaredfholgate merged commit a6bfafd into main Oct 8, 2024
4 checks passed
@jaredfholgate jaredfholgate deleted the feat-refactor-to-modules-and-add-ddos branch October 8, 2024 16:08
jaredfholgate added a commit to Azure/ALZ-PowerShell-Module that referenced this pull request Oct 8, 2024
# Pull Request

## Description

Support for multiple input files that get merged together.

Docs updates for new version of complete-multi-region Terraform module.

Associated PR for starter module:
Azure/alz-terraform-accelerator#175

## License

By submitting this pull request, I confirm that my contribution is made
under the terms of the projects associated license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants