-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: refactor to modules and add ddos #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtracey93
approved these changes
Oct 8, 2024
jaredfholgate
added a commit
to Azure/ALZ-PowerShell-Module
that referenced
this pull request
Oct 8, 2024
# Pull Request ## Description Support for multiple input files that get merged together. Docs updates for new version of complete-multi-region Terraform module. Associated PR for starter module: Azure/alz-terraform-accelerator#175 ## License By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
Replacing the complete-multi-region starter module with a modular implementation that leverages native Terraform inputs.
Also adding ddos plan and other minor fixes / improvements.
Please note that the
examples
folder and theyaml.tf
file are deleted by the ALZ PowerShell module, so they do not get pushed to source control.The purpose of the
yaml.tf
file is to enable us to spit out a config YAML file that is used in the docs since we now use a tfvars files for the local testing. See the sister PR for those files: Azure/ALZ-PowerShell-Module#214This PR fixes/adds/changes/removes
N/A
Breaking Changes
This is a breaking change to the complete-multi-region starter module.
Testing Evidence
Please provide any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
main
branch